fix(dialog.liquid): add missing name attribute to open and close buttons
This commit is contained in:
parent
5d956c60d5
commit
42446b370e
3 changed files with 4 additions and 2 deletions
|
@ -6,11 +6,11 @@
|
||||||
{%- endif -%}
|
{%- endif -%}
|
||||||
{%- endcapture -%}
|
{%- endcapture -%}
|
||||||
{% assign dialogId = id | default:"dialog-controls" %}
|
{% assign dialogId = id | default:"dialog-controls" %}
|
||||||
<button class="dialog-open client-side" data-dialog-trigger="{{ dialogId }}" data-dialog-button>
|
<button class="dialog-open client-side" name="{{ label }}" data-dialog-trigger="{{ dialogId }}" data-dialog-button>
|
||||||
{{ labelContent }}
|
{{ labelContent }}
|
||||||
</button>
|
</button>
|
||||||
<dialog id="dialog-{{ dialogId }}" class="client-side">
|
<dialog id="dialog-{{ dialogId }}" class="client-side">
|
||||||
<button class="dialog-close" data-dialog-button>
|
<button class="dialog-close" name="Close dialog" data-dialog-button>
|
||||||
{% tablericon "circle-x" %}
|
{% tablericon "circle-x" %}
|
||||||
</button>
|
</button>
|
||||||
{{ content }}
|
{{ content }}
|
||||||
|
|
|
@ -18,6 +18,7 @@
|
||||||
{% assign notes = item.notes | prepend: "### Notes\n" | markdown %}
|
{% assign notes = item.notes | prepend: "### Notes\n" | markdown %}
|
||||||
{% render "blocks/dialog.liquid",
|
{% render "blocks/dialog.liquid",
|
||||||
icon:"info-circle",
|
icon:"info-circle",
|
||||||
|
label:"View info about this concert"
|
||||||
content:notes,
|
content:notes,
|
||||||
id:item.content_date
|
id:item.content_date
|
||||||
%}
|
%}
|
||||||
|
|
|
@ -37,6 +37,7 @@ permalink: "/music/concerts/{% if pagination.pageNumber > 0 %}{{ pagination.page
|
||||||
{% assign notes = concert.notes | prepend: "### Notes\n" | markdown %}
|
{% assign notes = concert.notes | prepend: "### Notes\n" | markdown %}
|
||||||
{% render "blocks/dialog.liquid",
|
{% render "blocks/dialog.liquid",
|
||||||
icon:"info-circle",
|
icon:"info-circle",
|
||||||
|
label:"View info about this concert"
|
||||||
content:notes,
|
content:notes,
|
||||||
id:concert.id
|
id:concert.id
|
||||||
%}
|
%}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue